Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Auto instrumentation by telemetry type #11264

Closed
bcarter97 opened this issue May 1, 2024 · 4 comments
Closed

Disable Auto instrumentation by telemetry type #11264

bcarter97 opened this issue May 1, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@bcarter97
Copy link
Contributor

bcarter97 commented May 1, 2024

Is your feature request related to a problem? Please describe.

the library I am using does not carry trace information through threads, so auto instrumentation creates orphan spans which I would like to disable.

Describe the solution you'd like

I would like to disable auto instrumentation for tracing, while keeping the metrics. This would ideally happen through configuration.

Describe alternatives you've considered

specifically this is for gRPC and I have investigated using https://github.com/open-telemetry/opentelemetry-java-instrumentation/tree/main/instrumentation/grpc-1.6/library with success, however it requires a lot of boilerplate to achieve the same result as auto instrumentation.

Additional context

Originally discussed here, with the hope that OTEL_INSTRUMENTATION_<FRAMEWORK>_ENABLED: 'false' could be extended to something like OTEL_INSTRUMENTATION_<FRAMEWORK>_<INSTRUMENTATION_TYPE>_ENABLED: 'false'

@bcarter97 bcarter97 added enhancement New feature or request needs triage New issue that requires triage labels May 1, 2024
@laurit
Copy link
Contributor

laurit commented May 9, 2024

@bcarter97 see open-telemetry/opentelemetry-specification#3877 and open-telemetry/opentelemetry-java#6375 for the java implementation. You should be able to configure this via an extension when using the agent in the next version, this is new so not present in an existing release.

@laurit laurit added the needs author feedback Waiting for additional feedback from the author label May 9, 2024
@steverao steverao removed the needs triage New issue that requires triage label May 10, 2024
@bcarter97
Copy link
Contributor Author

Thanks, will this be documented in the extensions? I can't see any documentation added in the java impl

@github-actions github-actions bot removed the needs author feedback Waiting for additional feedback from the author label May 15, 2024
@trask
Copy link
Member

trask commented May 15, 2024

hi @bcarter97! eventually this will be easily configurable via system properties / yaml configuration file, but for now if you want to implement it you'll need wait for this week's release and then dive in and write your own java agent extension using these new experimental APIs

@bcarter97
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants