Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsitency of the API #1362

Closed
marcingrzejszczak opened this issue Oct 9, 2020 · 5 comments
Closed

Inconsitency of the API #1362

marcingrzejszczak opened this issue Oct 9, 2020 · 5 comments
Labels
contributor experience Something that we can do to improve the experience of contributors (especially new contributors)

Comments

@marcingrzejszczak
Copy link
Contributor

io.opentelemetry.instrumentation.api.tracer.HttpClientTracer have onRequest and onResponse whereas io.opentelemetry.instrumentation.api.tracer.HttpServerTracer has only onRequest method?
also in HttpServerTracer onRequest or onRequestAndConnection returns void whereas in HttpClientTracer returns Span.
@iNikem
Copy link
Contributor

iNikem commented Oct 10, 2020

We just recently migrated the majority of instrumentations to these new tracers. Their API is a complete mess right now. We will certainly review it.

@marcingrzejszczak
Copy link
Contributor Author

In general it's a great idea that works fine. I have some POC of extending the client & server tracers. I'm just wondering if it won't make more sense to extract the critical methods to an interface or make the methods public so that the library implementors can be sure that backward compatibility will be maintained.

@iNikem
Copy link
Contributor

iNikem commented Oct 11, 2020

Yes, that's the plan. Hopefully, soon :)

@iNikem iNikem added contributor experience Something that we can do to improve the experience of contributors (especially new contributors) priority:p2 labels Nov 4, 2020
@trask
Copy link
Member

trask commented Apr 3, 2021

this is being redesigned in #2596

@trask
Copy link
Member

trask commented Apr 3, 2021

Closing, implementation of new Instrumenter API is being tracked in #2713

@trask trask closed this as completed Apr 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
contributor experience Something that we can do to improve the experience of contributors (especially new contributors)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@trask @iNikem @marcingrzejszczak @mateuszrzeszutek