Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undertow span is finished before last servlet filter #2499

Closed
pavolloffay opened this issue Mar 4, 2021 · 2 comments · Fixed by #2560
Closed

Undertow span is finished before last servlet filter #2499

pavolloffay opened this issue Mar 4, 2021 · 2 comments · Fixed by #2560
Labels
bug Something isn't working

Comments

@pavolloffay
Copy link
Member

Describe the bug

Undertow instrumentation finishes server request span before the first servlet filter exits.

This has two implications:

  • potentially wrong timing information
  • additional instrumentation cannot add information to span in the servlet filter because the span has already been finished.

Steps to reproduce
https://github.com/wildfly/quickstart/blob/11.0.0.Final/jaxrs-client/src/main/java/org/jboss/as/quickstarts/jaxrsclient/rest/ContactResourceRESTService.java
Deploy on http://download.jboss.org/wildfly/10.1.0.Final/wildfly-10.1.0.Final.zip

What did you expect to see?

Span should be recording events after chain.doFilter(request, response);

What did you see instead?

Span is not recording events after chain.doFilter(request, response);

What version are you using?
0.17.0

Environment
JDK 11
WF 10.1.0

@pavolloffay pavolloffay added the bug Something isn't working label Mar 4, 2021
@pavolloffay
Copy link
Member Author

cc) @laurit

@pavolloffay
Copy link
Member Author

The issue seems to be present only for post request

curl -ivX POST -H "Content-Type: application/json" localhost:8080/jaxrs-client/rest/contacts -d '{"id": 15, "name": "jdoe"}'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant