Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create spans on new Netty connection #3319

Closed
iNikem opened this issue Jun 15, 2021 · 0 comments · Fixed by #3707
Closed

Create spans on new Netty connection #3319

iNikem opened this issue Jun 15, 2021 · 0 comments · Fixed by #3707
Labels
enhancement New feature or request

Comments

@iNikem
Copy link
Contributor

iNikem commented Jun 15, 2021

Netty instrumentation ChannelFutureListenerInstrumentation creates a span with special name CONNECT when connection failed to open. As creating new connection may be potentially an expensive operation there is a client request to capture all cases of creating new connection as span. Ideally with correct, non-zero, duration. This also will help exposing problems when connection pool does not work as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant