Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gRPC client interceptor: incorrect parent span attribution for spans following asynchronous calls #4088

Closed
evantorrie opened this issue Sep 10, 2021 · 0 comments · Fixed by #4097
Assignees
Labels
bug Something isn't working

Comments

@evantorrie
Copy link
Contributor

Describe the bug

Spans created after the completion of a gRPC client call are parented to the gRPC call span rather than the span that was active at the beginning of the client call.

Steps to reproduce
Create a span (P). Make an asynchronous unary gRPC call (A) using ClientCalls.futureUnaryCall. Set up a callback on completion to invoke another gRPC client call (B).

What did you expect to see?

Spans A and B should have the same parent (P)
Span A should end before Span B begins.

What did you see instead?

Span B is a child of Span A.
Span A continues until the completion of span B.

What version are you using?
v1.5.0

Environment
JDK: AdoptOpenJDK8
OS: RHEL7

Additional context
Discussed at Java instrumentation office-hours with @anuraaga, @trask and @jkwatson

@evantorrie evantorrie added the bug Something isn't working label Sep 10, 2021
@evantorrie evantorrie changed the title gRPC client interceptor: gRPC client interceptor: incorrect parent span attribution for spans following asynchronous calls Sep 10, 2021
@trask trask self-assigned this Sep 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants