Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicated/overlapping instrumentations #423

Closed
iNikem opened this issue May 20, 2020 · 0 comments · Fixed by #469
Closed

Duplicated/overlapping instrumentations #423

iNikem opened this issue May 20, 2020 · 0 comments · Fixed by #469
Assignees
@iNikem

Comments

@iNikem
Copy link
Contributor

iNikem commented May 20, 2020

It seems that Servlet3Instrumentation/Servlet2Instrumentation and HttpServletInstrumentation duplicate each other. They target almost the same methods of Servlet API, but do things somewhat differently. And their tests are very different as well. Should they be merged/unified in some way?
@iNikem iNikem mentioned this issue May 22, 2020
Merged
@iNikem iNikem self-assigned this May 25, 2020
This was referenced Jun 1, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iNikem iNikem

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Deduplicate servlets iNikem/opentelemetry-java-instrumentation
1 participant
@iNikem