Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.6.1 crashes when extension project is built with muzzle plugin 0.7.0 #4244

Closed
edwardxia opened this issue Sep 29, 2021 · 5 comments
Closed
Labels
bug Something isn't working

Comments

@edwardxia
Copy link

Commit 0d0d2ca in v1.6.1 which rename tons of muzzle related package names causes crash with extensions repository with muzzle plugin 0.7.0, and meanwhile muzzle plugin 0.8.0 is not yet released.

Caused by: java.lang.NoClassDefFoundError: io/opentelemetry/javaagent/extension/muzzle/Flag
        at java.base/java.lang.Class.getDeclaredConstructors0(Native Method)
        at java.base/java.lang.Class.privateGetDeclaredConstructors(Class.java:3137)
        at java.base/java.lang.Class.getConstructor0(Class.java:3342)
        at java.base/java.lang.Class.getConstructor(Class.java:2151)
        at java.base/java.util.ServiceLoader$1.run(ServiceLoader.java:659)
        at java.base/java.util.ServiceLoader$1.run(ServiceLoader.java:656)
        at java.base/java.security.AccessController.doPrivileged(Native Method)
        at java.base/java.util.ServiceLoader.getConstructor(ServiceLoader.java:667)
        ... 22 more
Caused by: java.lang.ClassNotFoundException: io.opentelemetry.javaagent.extension.muzzle.Flag
        at java.base/java.net.URLClassLoader.findClass(URLClassLoader.java:471)
        at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:589)
        at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:522)
        ... 30 more
@edwardxia edwardxia added the bug Something isn't working label Sep 29, 2021
@edwardxia
Copy link
Author

I don't understand how a breaking change get into a patch release. I see two ways out:

  • Revert this commit and release 1.6.2 ASAP. - This option is probably more appropriate.
  • Release muzzle plugin 0.8.0 and clarify that 1.6.1 will need muzzle plugin 0.8.0

@trask
Copy link
Member

trask commented Sep 29, 2021

oh no 😞, thanks for reporting this

unfortunately the 1.6.0 tag depended on a gradle-plugins snapshot, which made releasing 1.6.1 really painful. i think the best is to revert everything in the 1.6.x branch and release 1.6.2 which is essentially the same as 1.6.0, and give up on making a patch release for #4191

@trask
Copy link
Member

trask commented Sep 29, 2021

oh, and of course we can't just roll back and release 1.6.2 as a copy of 1.6.0, because the problem is that the 1.6.0 tag doesn't build anymore 😭

in the meantime, I've added a warning to the release notes, and posted the warning in the slack channel

@edwardxia
Copy link
Author

That is unfortunate, but thanks for getting to it quickly!

@trask
Copy link
Member

trask commented Sep 30, 2021

1.6.2 is released, please let us know if it resolves the issue for you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants