Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow adding custom conditions to Instrumenter#shouldStart() #4389

Open
mateuszrzeszutek opened this issue Oct 15, 2021 · 0 comments
Open

Allow adding custom conditions to Instrumenter#shouldStart() #4389

mateuszrzeszutek opened this issue Oct 15, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@mateuszrzeszutek
Copy link
Member

Is your feature request related to a problem? Please describe.
Currently there is no way to embed some additional conditions into the Instrumenter#shouldStart() method. There are several instrumentations that have additional checks (netty-4.1 client, jaxrs-1.1, cxf, ...)

Describe the solution you'd like
We could add an additional interface that accepts (REQUEST, Context) and returns a boolean - and add a new configuration knob for it to the InstrumenterBuilder.

Describe alternatives you've considered
Leave the code in those instrumentations as it is.

Additional context
#4381 (comment)

@mateuszrzeszutek mateuszrzeszutek added the enhancement New feature or request label Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant