Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-think our net attributes extractors #4408

Closed
mateuszrzeszutek opened this issue Oct 18, 2021 · 0 comments · Fixed by #4420
Closed

Re-think our net attributes extractors #4408

mateuszrzeszutek opened this issue Oct 18, 2021 · 0 comments · Fixed by #4420
Labels
bug Something isn't working

Comments

@mateuszrzeszutek
Copy link
Member

Describe the bug
Currently we have a NetServerAttributesExtractor that extracts net.* attributes on start and a NetClientAttributesExtractor that extracts net.* attributes on end. As it turned out in #4381, some HTTP client instrumentations (netty) need to capture net attributes on start, because they become unavailable at the end of request processing in some scenarios (timeouts in this particular case).
Perhaps we should go back to the NetOn(Start|End)AttributesExtractor naming? Or something else, e.g. Net(Request|Response)AttributesExtractor?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@mateuszrzeszutek