Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kafka Springboot Auto Instrumentation #4636

Closed
urwah1996 opened this issue Nov 13, 2021 · 1 comment · Fixed by #6371
Closed

Kafka Springboot Auto Instrumentation #4636

urwah1996 opened this issue Nov 13, 2021 · 1 comment · Fixed by #6371
Labels
contribution welcome Request makes sense, maintainers probably won't have time, contribution would be welcome enhancement New feature or request

Comments

@urwah1996
Copy link

Hi!
We are using opentelemetry spring boot autoconfigure sdk to bring tracing to our microservices. We have included the sdk as a dependency. As of now it is instrumenting http calls and rest template client calls to downstream services.
We are using Kafka messaging heavily in our microservices. I came across open telemetry instrumentation for kafka clients. This instrumentation will require manually wrapping the kafka consumers and producers with TracingConsumer and TracingProducer respectively.

I wanted to know if it is in the pipeline to autoconfigure TracingProducer and TracingConsumer during spring boot application startup. Just like spring cloud sleuth has post processors for producer and consumer

Any kind of help or direction would be really appreciated!
Thanks :)

@urwah1996 urwah1996 added the enhancement New feature or request label Nov 13, 2021
@mateuszrzeszutek
Copy link
Member

Spring-kafka has the RecordInterceptor and BatchInterceptor interfaces that I believe would provide better instrumentation than the plain kafka-clients one (and we already have a spring-kafka javaagent instrumentation that uses BatchInterceptor; perhaps it could be refactored to a library+javaagent instrumentation).
I don't think we have this in the pipeline, but any help with that would be very much appreciated.

@mateuszrzeszutek mateuszrzeszutek added the contribution welcome Request makes sense, maintainers probably won't have time, contribution would be welcome label Nov 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution welcome Request makes sense, maintainers probably won't have time, contribution would be welcome enhancement New feature or request
Projects
None yet
2 participants