You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
// Use http.target when http.route is not available.
if (!containsAttribute(SemanticAttributes.HTTP_ROUTE, startAttributes, endAttributes)) {
fullSet = durationServerFallbackView;
}
@jsuereth I know you had wanted http.target as a fallback since we aren't capturing http.route consistently yet, and metrics aren't nearly as useful without any route-like dimension. @mateuszrzeszutek has started the work on capturing http.route (#4852) but that work may not be finished in time for 1.10.0, so we need to make a decision on what to do in 1.10.0 release (and hopefully we'll have real solution, with http.route, in the next month or so).
The text was updated successfully, but these errors were encountered:
@mateuszrzeszutek has started the work on capturing http.route (#4852) but that work may not be finished in time for 1.10.0
Yep, I might not be able to finish that this week (most likely not) - the micrometer work took a lot of time to finish. Should we just remove http.target for the time being? And/or add a property that allows including it as an attribute?
From @anuraaga's #4930 (comment):
@jsuereth I know you had wanted
http.target
as a fallback since we aren't capturinghttp.route
consistently yet, and metrics aren't nearly as useful without any route-like dimension. @mateuszrzeszutek has started the work on capturinghttp.route
(#4852) but that work may not be finished in time for 1.10.0, so we need to make a decision on what to do in 1.10.0 release (and hopefully we'll have real solution, withhttp.route
, in the next month or so).The text was updated successfully, but these errors were encountered: