Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reactor-netty HttpClient: client span includes subscribe time #6607

Closed
lmolkova opened this issue Sep 13, 2022 · 1 comment
Closed

reactor-netty HttpClient: client span includes subscribe time #6607

lmolkova opened this issue Sep 13, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@lmolkova
Copy link
Contributor

A spin-off from #6593

Subscribe callback time is included in Http client span duration. Per offline conversation with @trask this violates the contract for HTTP client instrumentation and results in requestWithCallbackAndNoParent() test not working for netty after changing context propagation in #6593

E.g. if I do this:

HttpClient.ResponseReceiver<?> request = HttpClient.create().request(HttpMethod.valueOf("GET")).uri("https://blank.com");

request.responseSingle((resp, content) -> content.map(unused -> resp))
    .subscribe(
        response -> {
            try {
                Thread.sleep(1000);
            } catch (InterruptedException e) {
                throw new RuntimeException(e);
            }
        });

image

@lmolkova lmolkova added the bug Something isn't working label Sep 13, 2022
@lmolkova
Copy link
Contributor Author

closed in #7737

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant