Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More duplicate metric definitions for micrometer shim #4510

Closed
tylerlance opened this issue Jun 1, 2022 · 2 comments
Closed

More duplicate metric definitions for micrometer shim #4510

tylerlance opened this issue Jun 1, 2022 · 2 comments
Labels
Bug Something isn't working

Comments

@tylerlance
Copy link

tylerlance commented Jun 1, 2022

Hello.

This is a duplicate of 4381, but I wanted to bring this to your attention as this was assumed to be a rare scenario.

It appears the descriptions of Resilience4J meters are differentiated by descriptions.

[main] WARN io.opentelemetry.sdk.metrics.internal.state.MetricStorageRegistry - Found duplicate metric definition: resilience4j.circuitbreaker.calls
	at unknown source
		To enable better debugging, run your JVM with -Dotel.experimental.sdk.metrics.debug=true
Causes
- Description [Total number of failed calls] does not match [Total number of successful calls]
- InstrumentDescription [Total number of failed calls] does not match [Total number of successful calls]
Original instrument registered with same name but is incompatible.

Ideally we would want all these metrics sent to the collector, not just potentially the first one that was instrumented. Is the expectation going forward to update the descriptions in these other repos? Change the approach in this repo? Or should we be adding a MeterFilter to change the descriptions?

Current dependencies are:
micrometer-core v1.9.0
opentelemetry v1.14.0
resilience4j-spring-boot2 v1.7.1

@tylerlance tylerlance added the Bug Something isn't working label Jun 1, 2022
@jack-berg
Copy link
Member

Currently, all are sent to the collector. The warning you see is just a warning but both of the duplicate definitions are exported.

#4457 fixes this generally for micrometer metrics by caching the first seen description for a given metric name, and using that first description for subsequent instruments with the same name. This will be included in the upcoming 1.15.0 release.

@tylerlance
Copy link
Author

Thanks @jack-berg. I'll close this issue and wait for the 1.15.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants