Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hasAttributesSatisfying vs hasAttributesSatisfyingExactly #4778

Closed
trask opened this issue Sep 24, 2022 · 4 comments · Fixed by #4882
Closed

hasAttributesSatisfying vs hasAttributesSatisfyingExactly #4778

trask opened this issue Sep 24, 2022 · 4 comments · Fixed by #4882
Assignees

Comments

@trask
Copy link
Member

trask commented Sep 24, 2022

SpanDataAssert has hasAttributesSatisfying and hasAttributesSatisfyingExactly, while AbstractPointAssert has only hasAttributesSatisfying but with behavior matching SpanDataAssert's hasAttributesSatisfyingExactly

DoubleExemplarAssert and LongExemplarAssert also have hasFilteredAttributesSatisfying, which matches the "*Exactly" behavior

Unfortunately I don't have any good ideas for what to do about it given stability of the artifact, but I did find it confusing when using AbstractPointAssert, I originally came here to open an issue about it missing an "*Exactly" variant before I dug a little further.

@jkwatson
Copy link
Contributor

That sounds like a bug that needs to be fixed, which we can definitely do in stable artifacts.

@jack-berg
Copy link
Member

So adjust the metrics has(.*)AttributesSatisfying assertion behavior to match SpanDataAssert#hasAttributesSatisfying, and add new metric hasAttributesSatisfyingExactly variants which match SpanDataAssert#hasAttributesSatisfyingExactly ?

@trask
Copy link
Member Author

trask commented Sep 26, 2022

this would satisfy me

@lmonkiewicz
Copy link
Contributor

I would gladly take care of this issue, can it be assigned to me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants