Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove labels keys from instruments #1121

Merged
merged 1 commit into from
Apr 20, 2020

Conversation

bogdandrutu
Copy link
Member

@codecov-io
Copy link

Codecov Report

Merging #1121 into master will decrease coverage by 0.13%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1121      +/-   ##
============================================
- Coverage     85.68%   85.54%   -0.14%     
+ Complexity     1081     1078       -3     
============================================
  Files           138      138              
  Lines          3974     3965       -9     
  Branches        351      351              
============================================
- Hits           3405     3392      -13     
- Misses          428      431       +3     
- Partials        141      142       +1     
Impacted Files Coverage Δ Complexity Δ
...in/java/io/opentelemetry/metrics/DefaultMeter.java 70.29% <ø> (-0.58%) 9.00 <0.00> (ø)
...etry/contrib/metrics/runtime/GarbageCollector.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...telemetry/contrib/metrics/runtime/MemoryPools.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
.../opentelemetry/sdk/metrics/AbstractInstrument.java 94.23% <100.00%> (-0.42%) 10.00 <0.00> (ø)
...pentelemetry/sdk/metrics/InstrumentDescriptor.java 100.00% <100.00%> (ø) 2.00 <1.00> (ø)
...src/main/java/io/opentelemetry/internal/Utils.java 78.18% <0.00%> (-9.10%) 24.00% <0.00%> (-3.00%)
...elemetry/sdk/trace/export/BatchSpansProcessor.java 91.72% <0.00%> (-1.51%) 9.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c32c776...5c510e8. Read the comment docs.

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@bogdandrutu bogdandrutu merged commit 6a4fd2d into open-telemetry:master Apr 20, 2020
@bogdandrutu bogdandrutu deleted the labelkeys branch April 20, 2020 16:24
davebarda pushed a commit to davebarda/opentelemetry-java that referenced this pull request Apr 24, 2020
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@jkwatson jkwatson added this to the May Release milestone May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants