Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser document-load plugin occasionally has start date after end date for spans. #1013

Closed
crobertson-conga opened this issue May 6, 2022 · 3 comments
Labels
bug Something isn't working stale

Comments

@crobertson-conga
Copy link

crobertson-conga commented May 6, 2022

Occasionally the documentFetch and resourceFetch spans being generated by the document-load plugin have negative durations (start time after end).

What version of OpenTelemetry are you using?

{"telemetry.sdk.language":"webjs","telemetry.sdk.name":"opentelemetry","telemetry.sdk.version":"1.0.1"}
{"name":"@opentelemetry/instrumentation-document-load","version":"0.25.0"}

What version of Node are you using?

N/A this is browser-based.

Sample of User-Agents affected
Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/66.0.3359.181 Safari/537.36
Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Firefox/91.0
Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/100.0.4896.127 Safari/537.36
Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/52.0.2743.116 Safari/537.36 Edge/15.15063
Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.102 Safari/537.36 Edge/18.18363
Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:100.0) Gecko/20100101 Firefox/100.0
Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/64.0.3282.140 Safari/537.36 Edge/18.17763
Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.102 Safari/537.36 Edge/18.18362
Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:99.0) Gecko/20100101 Firefox/99.0
Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/64.0.3282.140 Safari/537.36 Edge/17.17134

What did you do?

under load, occasionally the documentFetch and resourceFetch metrics will have the start date after the end date causing negative durations. This causes some downstream effects (such as crashing spanmetrics processor in the collector).

What did you expect to see?

The start date for a span should always be before or at the same time as the end date.

What did you see instead?

End dates are sometimes a few milliseconds before start times. Attached is a view of some of those traces dumped into Kusto
Screen Shot 2022-05-06 at 12 34 04 PM

Additional context

@github-actions
Copy link
Contributor

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale label Jul 11, 2022
@github-actions
Copy link
Contributor

This issue was closed because it has been stale for 14 days with no activity.

@crobertson-conga
Copy link
Author

This is still a concern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working stale
Projects
None yet
1 participant