Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using gts instead of eslint #1433

Closed
samimusallam opened this issue Mar 19, 2023 · 4 comments · Fixed by #1439, #1485 or #1488
Closed

Using gts instead of eslint #1433

samimusallam opened this issue Mar 19, 2023 · 4 comments · Fixed by #1439, #1485 or #1488

Comments

@samimusallam
Copy link
Member

I've been having some issues with eslint's configuration as it is configured as part of the gts module. Is there a specific reason for using gts instead of eslint, prettier, etc just like in the core repo?

@Flarna
Copy link
Member

Flarna commented Mar 20, 2023

As far as I remember gts was the tool of choice in the early OTel days. it was removed in core repo because of some dependency issues. There were other build setup changes done in core repo that time like using a single typescript project.

The idea was to do the same in contrib as followup but noone found the time to do this.

@samimusallam
Copy link
Member Author

As far as I remember gts was the tool of choice in the early OTel days. it was removed in core repo because of some dependency issues. There were other build setup changes done in core repo that time like using a single typescript project.

The idea was to do the same in contrib as followup but noone found the time to do this.

I can create a PR for this. Is there anything else that should be done that was also changed in the core repo?

@Flarna
Copy link
Member

Flarna commented Mar 22, 2023

Can't remember in detail. I guess the only way is to compare the repos. Maybe browser tooling like webpack differ also. Maybe also typescript, lerna,...

But there is no need to create a single PR to cover everything. Usually such repo wide changes tend to be complicated/cumbersome even if you touch just a part.

@samimusallam
Copy link
Member Author

Can't remember in detail. I guess the only way is to compare the repos. Maybe browser tooling like webpack differ also. Maybe also typescript, lerna,...

But there is no need to create a single PR to cover everything. Usually such repo wide changes tend to be complicated/cumbersome even if you touch just a part.

Agreed. Will start with a small PR for gts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment