Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opentelemetry-instrumentation-aws-lambda silently fails to instrument files with the extension.cjs #1440

Closed
Ankcorn opened this issue Mar 28, 2023 · 3 comments
Assignees
Labels
bug Something isn't working priority:p2 Bugs and spec inconsistencies which cause telemetry to be incomplete or incorrect

Comments

@Ankcorn
Copy link
Contributor

Ankcorn commented Mar 28, 2023

What version of OpenTelemetry are you using?

Will be upgrading to the latest
"@opentelemetry/api": "^1.3.0",
"@opentelemetry/exporter-trace-otlp-http": "^0.34.0",
"@opentelemetry/instrumentation": "^0.34.0",
"@opentelemetry/instrumentation-aws-lambda": "^0.34.0",
"@opentelemetry/instrumentation-aws-sdk": "^0.33.0",
"@opentelemetry/instrumentation-http": "^0.34.0",
"@opentelemetry/sdk-trace-base": "^1.8.0",
"@opentelemetry/sdk-trace-node": "^1.8.0",

What version of Node are you using?

v16.x

What did you do?

https://github.com/baselime/lambda-node-opentelemetry-serverless-stack-v2
Here is a repo reproducing the issue

What did you expect to see?

Traces sent

What did you see instead?

lambda handler is not instrumented

Additional context

issue is this line of code does not handle all possible options supported by lambda node runtime

@dyladan
Copy link
Member

dyladan commented Mar 29, 2023

@willarmiros can you please look into this and the linked PR?

@dyladan dyladan added the priority:p2 Bugs and spec inconsistencies which cause telemetry to be incomplete or incorrect label Apr 5, 2023
@Ankcorn
Copy link
Contributor Author

Ankcorn commented May 16, 2023

Thanks for getting this published!

I just saw this open-telemetry/opentelemetry-js#3698 pr was closed!

I realize that makes my fix a little half baked. sorry .mjs files...

Should I make a new issue to track that @dyladan

@dyladan
Copy link
Member

dyladan commented May 16, 2023

Yes

@dyladan dyladan closed this as completed May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority:p2 Bugs and spec inconsistencies which cause telemetry to be incomplete or incorrect
Projects
None yet
Development

No branches or pull requests

3 participants