Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fastify] Pass all spans to requestHook #2219

Open
mydea opened this issue May 17, 2024 · 0 comments
Open

[Fastify] Pass all spans to requestHook #2219

mydea opened this issue May 17, 2024 · 0 comments

Comments

@mydea
Copy link
Contributor

mydea commented May 17, 2024

In the fastify instrumentation, only request_handler spans are passed to requestHook. This means there is no (easy) way to customize the middleware spans the instrumentation emits. This is different than e.g. in the express instrumentation, where all spans are passed to the requestHook. I think it would make sense to align this and also pass all spans to requestHook in fastify.

If this is OK, I could prepare a PR to change this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant