You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe
When using producer.send or producer.sendBatch to send multiple messages, a span is created for every message sent. This creates a lot of noise when bulk sending messages (We frequently send 1000s of events in a single bulk call), and this is not how kafkaJS produces messages, which seems to be only split by topic/partition/broker.
The above snippet would create 2 spans currently, even though there is only 1 call to send and KafkaJS will send these to the broker in a single request.
Thanks!
The text was updated successfully, but these errors were encountered:
Is your feature request related to a problem? Please describe
When using
producer.send
orproducer.sendBatch
to send multiple messages, a span is created for every message sent. This creates a lot of noise when bulk sending messages (We frequently send 1000s of events in a single bulk call), and this is not how kafkaJS produces messages, which seems to be only split by topic/partition/broker.See here for message sending logic in KafkaJS which is used for
send
andsendBatch
: https://github.com/tulios/kafkajs/blob/master/src/producer/sendMessages.js#L17Example
Describe the solution you'd like to see
I think this could either be configurable to only add spans to each call to
producer.send
(maybe include a messageCount attribute)Example
OR the logic could be changed to wrap
broker.produce
(is this possible?) which would more closely represent how KafkaJS interacts with the broker.Additional context
The above snippet would create 2 spans currently, even though there is only 1 call to
send
and KafkaJS will send these to the broker in a single request.Thanks!
The text was updated successfully, but these errors were encountered: