Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't release a new package version if the only change is devDep updates #2250

Open
trentm opened this issue May 31, 2024 · 2 comments
Open

Comments

@trentm
Copy link
Contributor

trentm commented May 31, 2024

Would it be possible to have the release-please release automatic not bother with a new release for a particular package if the only change in that package has been to its devDeps?

For example, if you look at #2211, most of the new package versions there are because there was a change in the contrib-test-utils devDep. IMHO that's not worth a new release of a package. The result is unnecessary churn.

@JamieDanielson
Copy link
Member

I can go either way here. I wonder if there is a way we can specify certain packages to be exempt. Some dependencies like TypeScript can have an impact on released versions. At least major TypeScript versions, with some config changes and/or generated types files.

Although I guess we don't have to release yet either - this will accumulate changes if we leave it open right? So maybe it's just a note to hold off on merging the PR for release until we feel there's enough reason to publish a new release.

@trentm
Copy link
Contributor Author

trentm commented Jun 5, 2024

Some dependencies like TypeScript can have an impact on released versions.

Touché

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants