Codecov Report

Attention: Patch coverage is 75.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 90.36%. Comparing base (dfb2dff) to head (101e47f).
Report is 149 commits behind head on main.

@@            Coverage Diff             @@
##             main    #2256      +/-   ##
==========================================
- Coverage   90.97%   90.36%   -0.62%     
==========================================
  Files         146      148       +2     
  Lines        7492     7524      +32     
  Branches     1502     1576      +74     
==========================================
- Hits         6816     6799      -17     
- Misses        676      725      +49     

Once some tests are added, this looks good to me. As for how you might go about doing that - would it be possible to recreate the scenario with the ioredis package that was calling endSpan multiple times and then use sinon to assert that with the new changes the endSpan method is only ever called once under those conditions?

use sinon to assert that with the new changes the endSpan method is only ever called once under those conditions

I'm struggling figuring out a good way to spy on the returned span here. I have something like so:

let endSpanSpy;
const original = instrumentation['tracer'].startSpan;
sinon
  .stub(instrumentation['tracer'], 'startSpan')
  .callsFake((name, options, context) => {
    const span = original(name, options, context);
    endSpanSpy = sinon.spy(span, 'end');
    return span;
  });

but that seems to be causing issues for some reason.

Alright I have it something like so:

const endSpanSpy = sinon.spy(OtelSpan.prototype, 'end');
const span = provider.getTracer('ioredis-test').startSpan('test span');
try {
  await context.with(trace.setSpan(context.active(), span), () => {
    return client.set('non-int-key', 'non-int-value').then(() => {
      return client.incr('non-int-key', () => {
        throw new Error('This is an error');
      });
    });
  });
} catch (e) {
  // ignore
}

console.log(endSpanSpy.callCount);

but the mocha after hooks don't seem to like this 😢. My inexperience with mocha/sinon really showing here 😓