-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hook to access response in instrumentation-undici #2265
Comments
It doesn't look like it would be that easy to add a Using the {
responseHook?: (span: Span, request: UndiciRequest, response: UndiciResponse): void;
} |
yeah, this is basically what I would have thought of :) that would be great! |
would this request be related to #2179? |
Probably, it's basically a generic hook that gives access to both request and response at the same time, which can be used for more specialised needs. |
It would be great to have a hook that allows us access to request & response in instrumentation-undici.
Would you be open to add support for this? If so, I could work on a PR adding this. I am thinking about something like this which exists in instrumentation-http:
Alternatively, if we could make certain things protected (e.g.
subscribeToChannel
) we could also extend the instrumentation class and add such things ourselves. If that's preferable I could also PR this?The text was updated successfully, but these errors were encountered: