-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(instr-undici): respect requireParent flag when INVALID_SPAN_CONTEXT is used #2273
fix(instr-undici): respect requireParent flag when INVALID_SPAN_CONTEXT is used #2273
Conversation
Hi @reberhardt7 1st of all thanks for contributing to OpenTelemetry :) Could you please sign the CLA so we can proceed on moving your PR forward? Thanks! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2273 +/- ##
==========================================
- Coverage 90.97% 90.29% -0.68%
==========================================
Files 146 147 +1
Lines 7492 7246 -246
Branches 1502 1504 +2
==========================================
- Hits 6816 6543 -273
- Misses 676 703 +27
|
@david-luna I've signed the CLA now. Thank you :) |
cf10ea0
to
0506cea
Compare
@david-luna thanks for the review! Would you be the right person to take a look at this analogous instrumentation-http PR, or would that be someone else? |
@reberhardt7 I can give my review and notice the members of the SIG to get another approval |
Which problem is this PR solving?
This PR mirrors this fix in the http instrumentation: open-telemetry/opentelemetry-js#4788
Short description of the changes
This checks whether the parent span is recording, and does not create a real child span if the parent isn't recording.