You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Perform instrumentation with @opentelemetry/instrumentation-graphql.
What did you expect to see?
Graphql should not be imported as a dependency by the instrumentation
What did you see instead?
graphql:16.0.1 was imported and created a conflict with our version.
Additional context
We just saw an issue in the graphql instrumentation where it adds graphql as dependency to our instrumentation code. When exploring the issue, we saw that the @types/graphql dependency (v 14.5.0) is the one that added the graphql (v 16.0.1) as a dependency.
(You can see it here: https://libraries.io/npm/@types%2Fgraphql/14.5.0/tree)
BTW, it appears that this behavior was introduced in @types/graphql:14.5.0 and was not there in 14.2.3. Also, checking npm is seems that 14.5.0 was deprecated)
We saw that the @types libs were moved to the main dependencies list from the dev-list in this commit .
We suggested moving back to @types/graphql:14.2.3 if possible.
The text was updated successfully, but these errors were encountered:
nata7che
changed the title
Graphql is added as dependency by instrumentation
Graphql is added as dependency by instrumentation and may case version collision
Dec 1, 2021
What version of OpenTelemetry are you using?
"@opentelemetry/api": "^1.0.3",
"@opentelemetry/core": "^1.0.0",
"@opentelemetry/instrumentation": "^0.26.0",
"@opentelemetry/instrumentation-graphql": "^0.26.0",
What version of Node are you using?
node v15.12.0 (npm v7.6.3)
What did you do?
Perform instrumentation with @opentelemetry/instrumentation-graphql.
What did you expect to see?
Graphql should not be imported as a dependency by the instrumentation
What did you see instead?
graphql:16.0.1 was imported and created a conflict with our version.
Additional context
We just saw an issue in the graphql instrumentation where it adds graphql as dependency to our instrumentation code. When exploring the issue, we saw that the @types/graphql dependency (v 14.5.0) is the one that added the graphql (v 16.0.1) as a dependency.
(You can see it here: https://libraries.io/npm/@types%2Fgraphql/14.5.0/tree)
BTW, it appears that this behavior was introduced in @types/graphql:14.5.0 and was not there in 14.2.3. Also, checking npm is seems that 14.5.0 was deprecated)
We saw that the @types libs were moved to the main dependencies list from the dev-list in this commit .
We suggested moving back to @types/graphql:14.2.3 if possible.
The text was updated successfully, but these errors were encountered: