From b0e4066804013b8c53829d630f40460e6297b3fa Mon Sep 17 00:00:00 2001 From: Jamie Danielson Date: Mon, 25 Nov 2024 12:18:40 -0500 Subject: [PATCH 1/3] docs: update contributing guidelines for required org membership --- CONTRIBUTING.md | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index c3cbc3f38e..76d2ab0a16 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -140,6 +140,7 @@ When two or more approaches must be compared, please write a benchmark in the be This repository contains many components which are maintained by more than the typical set of JS maintainers and approvers. Each component in this repository SHOULD have a component owner who is responsible for maintaining it. The README.md for each component SHOULD contain its owner, but the source of truth for component ownership is in [.github/component_owners.yml](.github/component_owners.yml). +Each component owner SHOULD be listed in CODEOWNERS with the path to the component. Component owners are generally given authority to make decisions relating to implementation and feature requests for their components, provided they follow the best practices set out by the maintainers and the [mission, vision and values](https://github.com/open-telemetry/community/blob/main/mission-vision-values.md) of the OpenTelemetry Project. @@ -149,6 +150,9 @@ Maintainers may override the decisions of component owners, but should only do s ### Becoming a Component Owner +To become a component owner, contributors MUST be a member of the OpenTelemetry GitHub organization. +To become a member, follow the steps in the [community guidelines for membership requirements](https://github.com/open-telemetry/community/blob/main/guides/contributor/membership.md#requirements). + To become a component owner, contributors SHOULD demonstrate prior knowledge of the instrumented package or the concepts therein. Ways do to so may be by providing proof of: @@ -306,6 +310,7 @@ When instrumentation cannot be included in a target package and there is good re Note that new instrumentation needs at least two contributors assigned to it as code-owners. It is the responsibility of the requesting party to reach out and find code-owners for the proposed instrumentation. The instrumentation request needs to be accepted before any pull requests for the instrumentation can be considered for merging. +Review the guidelines for [Becoming a Component Owner](#becoming-a-component-owner). Regardless of where instrumentation is hosted, it needs to be discoverable. The [OpenTelemetry registry](https://opentelemetry.io/registry/) exists to ensure that instrumentation is discoverable. From 122df43dbf92c00a055337a10ffa4f6b82d6865c Mon Sep 17 00:00:00 2001 From: Jamie Danielson Date: Mon, 25 Nov 2024 12:20:59 -0500 Subject: [PATCH 2/3] add note about triager role and codeowners file --- CONTRIBUTING.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 76d2ab0a16..ae5e9706c1 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -181,6 +181,7 @@ If all these conditions are met, aspiring component owners are encouraged to sel information provided on the issue - either approve or deny the ownership request. If the ownership request has been approved, the new component owner opens a PR to add themselves to the list of owners ([.github/component_owners.yml](.github/component_owners.yml)) for that package. +@open-telemetry/javascript-maintainers will add the component owner to @open-telemetry/javascript-contrib-triagers and to the CODEOWNERS file. ## Component Lifecycle From 66749edb4d997d4aeb29239b7e487937d6702020 Mon Sep 17 00:00:00 2001 From: Jamie Danielson Date: Mon, 2 Dec 2024 11:29:24 -0500 Subject: [PATCH 3/3] remove codeowner requirement, component owner is fine --- CONTRIBUTING.md | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index ae5e9706c1..a8c9a52285 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -140,7 +140,6 @@ When two or more approaches must be compared, please write a benchmark in the be This repository contains many components which are maintained by more than the typical set of JS maintainers and approvers. Each component in this repository SHOULD have a component owner who is responsible for maintaining it. The README.md for each component SHOULD contain its owner, but the source of truth for component ownership is in [.github/component_owners.yml](.github/component_owners.yml). -Each component owner SHOULD be listed in CODEOWNERS with the path to the component. Component owners are generally given authority to make decisions relating to implementation and feature requests for their components, provided they follow the best practices set out by the maintainers and the [mission, vision and values](https://github.com/open-telemetry/community/blob/main/mission-vision-values.md) of the OpenTelemetry Project. @@ -181,7 +180,7 @@ If all these conditions are met, aspiring component owners are encouraged to sel information provided on the issue - either approve or deny the ownership request. If the ownership request has been approved, the new component owner opens a PR to add themselves to the list of owners ([.github/component_owners.yml](.github/component_owners.yml)) for that package. -@open-telemetry/javascript-maintainers will add the component owner to @open-telemetry/javascript-contrib-triagers and to the CODEOWNERS file. +@open-telemetry/javascript-maintainers will add the component owner to @open-telemetry/javascript-contrib-triagers. ## Component Lifecycle