We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I'm a bit confused regarding the attributes?: SpanAttributes config in OTLP exporter.
attributes?: SpanAttributes
The config is of type SpanAttributes but actually it seems they end up in Resource, see here and here and here
SpanAttributes
Is the type in the interface wrong or do the attributes end up at the wrong place? Is this config required by spec?
As this is end user visible it's most likely good to clarify before the exporters are release as 1.x.
The text was updated successfully, but these errors were encountered:
I think this pre-date the ressource concept (a370a47#diff-1a3856739afae4654e870ec5308913f90261da0c0e589d8c1b27c84d6c6dab85R181) and was introduced orignally for adding span attributes which wasn't even used at the time. Then PR after PR the name stayed but ended up on the resource
Sorry, something went wrong.
This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.
I would prefer to remove as it is not part of the spec.
Flarna
Successfully merging a pull request may close this issue.
I'm a bit confused regarding the
attributes?: SpanAttributes
config in OTLP exporter.The config is of type
SpanAttributes
but actually it seems they end up in Resource, see here and here and hereIs the type in the interface wrong or do the attributes end up at the wrong place?
Is this config required by spec?
As this is end user visible it's most likely good to clarify before the exporters are release as 1.x.
The text was updated successfully, but these errors were encountered: