Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attributes config in OTLPExporters #2826

Closed
1 of 2 tasks
Flarna opened this issue Mar 9, 2022 · 3 comments · Fixed by #2991
Closed
1 of 2 tasks

attributes config in OTLPExporters #2826

Flarna opened this issue Mar 9, 2022 · 3 comments · Fixed by #2991
Assignees

Comments

@Flarna
Copy link
Member

Flarna commented Mar 9, 2022

  • This only affects the JavaScript OpenTelemetry library
  • This may affect other libraries, but I would like to get opinions here first

I'm a bit confused regarding the attributes?: SpanAttributes config in OTLP exporter.

The config is of type SpanAttributes but actually it seems they end up in Resource, see here and here and here

Is the type in the interface wrong or do the attributes end up at the wrong place?
Is this config required by spec?

As this is end user visible it's most likely good to clarify before the exporters are release as 1.x.

@Flarna Flarna changed the title attributes config for OTLPExporters attributes config in OTLPExporters Mar 9, 2022
@vmarchaud
Copy link
Member

I think this pre-date the ressource concept (a370a47#diff-1a3856739afae4654e870ec5308913f90261da0c0e589d8c1b27c84d6c6dab85R181) and was introduced orignally for adding span attributes which wasn't even used at the time. Then PR after PR the name stayed but ended up on the resource

@github-actions
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale label May 23, 2022
@dyladan
Copy link
Member

dyladan commented May 23, 2022

I would prefer to remove as it is not part of the spec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants