Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make aggregationTemporalitySelector an optional property #3213

Closed
pichlermarc opened this issue Aug 30, 2022 · 3 comments · Fixed by #3225
Closed

Make aggregationTemporalitySelector an optional property #3213

pichlermarc opened this issue Aug 30, 2022 · 3 comments · Fixed by #3225
Assignees
@pichlermarc
Labels
feature-request sdk:metrics Issues and PRs related to the Metrics SDK
Milestone
Metrics GA

Comments

@pichlermarc
Copy link
Member

We should make aggregationTemporalitySelector an optional property on the PushMetricExporter interface, and add logic to the MetricReader to default to AggregationTemproality.CUMULATIVE for all instruments if `aggregationTemporalitySelector is not there.

This would reduce duplicated code in third party exporters, while still allowing the exporter to override the default.
@pichlermarc pichlermarc added this to the Metrics GA milestone Aug 30, 2022
@pichlermarc
Copy link
Member Author

See also: #3153 (comment)

@pichlermarc
Copy link
Member Author

Requires #3153 to be merged first.

@pichlermarc pichlermarc mentioned this issue Aug 30, 2022
Merged
7 tasks
@legendecas legendecas added the sdk:metrics Issues and PRs related to the Metrics SDK label Sep 1, 2022
@pichlermarc
Copy link
Member Author

I can work on this. I'll self assign. 🙂

@pichlermarc pichlermarc self-assigned this Sep 1, 2022
@pichlermarc pichlermarc mentioned this issue Sep 2, 2022
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pichlermarc pichlermarc

Labels
feature-request sdk:metrics Issues and PRs related to the Metrics SDK
Projects
None yet
Milestone
Metrics GA
2 participants
@legendecas @pichlermarc