Flaky test in @opentelemetry/instrumentation-http

[pichlermarc]

Looks like #3149 introduced a slightly flaky test which is causing the build to fail.

Test in question:

opentelemetry-js/experimental/packages/opentelemetry-instrumentation-http/test/functionals/http-metrics.test.ts

Lines 67 to 103 in 597ea98

	it('should add server/client duration metrics', async () => {
	const requestCount = 3;
	for (let i = 0; i < requestCount; i++) {
	await httpRequest.get(`${protocol}://${hostname}:${serverPort}${pathname}`);
	}
	await new Promise(resolve => setTimeout(resolve, 300));
	const resourceMetrics = metricsMemoryExporter.getMetrics();
	const scopeMetrics = resourceMetrics[0].scopeMetrics;
	assert.strictEqual(scopeMetrics.length, 1, 'scopeMetrics count');
	const metrics = scopeMetrics[0].metrics;
	assert.strictEqual(metrics.length, 2, 'metrics count');
	assert.strictEqual(metrics[0].dataPointType, DataPointType.HISTOGRAM);
	assert.strictEqual(metrics[0].descriptor.description, 'measures the duration of the inbound HTTP requests');
	assert.strictEqual(metrics[0].descriptor.name, 'http.server.duration');
	assert.strictEqual(metrics[0].descriptor.unit, 'ms');
	assert.strictEqual(metrics[0].dataPoints.length, 1);
	assert.strictEqual((metrics[0].dataPoints[0].value as any).count, requestCount);
	assert.strictEqual(metrics[0].dataPoints[0].attributes[SemanticAttributes.HTTP_SCHEME], 'http');
	assert.strictEqual(metrics[0].dataPoints[0].attributes[SemanticAttributes.HTTP_METHOD], 'GET');
	assert.strictEqual(metrics[0].dataPoints[0].attributes[SemanticAttributes.HTTP_FLAVOR], '1.1');
	assert.strictEqual(metrics[0].dataPoints[0].attributes[SemanticAttributes.NET_HOST_NAME], 'localhost');
	assert.strictEqual(metrics[0].dataPoints[0].attributes[SemanticAttributes.HTTP_STATUS_CODE], 200);
	assert.strictEqual(metrics[0].dataPoints[0].attributes[SemanticAttributes.NET_HOST_PORT], 22346);
	assert.strictEqual(metrics[1].dataPointType, DataPointType.HISTOGRAM);
	assert.strictEqual(metrics[1].descriptor.description, 'measures the duration of the outbound HTTP requests');
	assert.strictEqual(metrics[1].descriptor.name, 'http.client.duration');
	assert.strictEqual(metrics[1].descriptor.unit, 'ms');
	assert.strictEqual(metrics[1].dataPoints.length, 1);
	assert.strictEqual((metrics[1].dataPoints[0].value as any).count, requestCount);
	assert.strictEqual(metrics[1].dataPoints[0].attributes[SemanticAttributes.HTTP_METHOD], 'GET');
	assert.strictEqual(metrics[1].dataPoints[0].attributes[SemanticAttributes.NET_PEER_NAME], 'localhost');
	assert.strictEqual(metrics[1].dataPoints[0].attributes[SemanticAttributes.NET_PEER_PORT], 22346);
	assert.strictEqual(metrics[1].dataPoints[0].attributes[SemanticAttributes.HTTP_STATUS_CODE], 200);
	assert.strictEqual(metrics[1].dataPoints[0].attributes[SemanticAttributes.HTTP_FLAVOR], '1.1');
	});
	});

See failures:

• https://github.com/open-telemetry/opentelemetry-js/runs/8232165991?check_suite_focus=true
• https://github.com/open-telemetry/opentelemetry-js/runs/8213720386?check_suite_focus=true

[pichlermarc]

I'll pick this up. 🙂