-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add http request metrics to either http or express package #3294
Comments
The newly released http instrumentation should allow you to do this: #3149 |
Liked metrics will all be added to http instrumentation, rather than express. I'll move this issue there, @icco. |
The necessary change has been released in @opentelemetry/instrumentation-http v0.33.0. I'm closing this as completed. |
Just to be clear @legendecas, that change only adds |
I will try and put together a PR to add those metrics. |
This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
This issue was closed because it has been stale for 14 days with no activity. |
Is your feature request related to a problem? Please describe
While I can figure out RPS from traces, if traces are sampled, this number is wrong.
Describe the solution you'd like to see
I would like to see the metrics described in https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/semantic_conventions/http-metrics.md exported by one of these two libraries.
Describe alternatives you've considered
Additional context
The text was updated successfully, but these errors were encountered: