Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add http request metrics to either http or express package #3294

Closed
icco opened this issue Sep 21, 2022 · 8 comments
Closed

Add http request metrics to either http or express package #3294

icco opened this issue Sep 21, 2022 · 8 comments
Assignees
Labels
question User is asking a question not related to a new feature or bug stale

Comments

@icco
Copy link

icco commented Sep 21, 2022

Is your feature request related to a problem? Please describe

While I can figure out RPS from traces, if traces are sampled, this number is wrong.

Describe the solution you'd like to see

I would like to see the metrics described in https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/semantic_conventions/http-metrics.md exported by one of these two libraries.

Describe alternatives you've considered

Additional context

@vmarchaud
Copy link
Member

The newly released http instrumentation should allow you to do this: #3149

@vmarchaud vmarchaud added the question User is asking a question not related to a new feature or bug label Sep 22, 2022
@icco
Copy link
Author

icco commented Sep 22, 2022

Oh that's cool. We have that version but haven't seen those metrics yet. I also would like the rest of the metrics in the spec implemented:

Screen Shot 2022-09-22 at 17 09 14

@rauno56
Copy link
Member

rauno56 commented Oct 5, 2022

Liked metrics will all be added to http instrumentation, rather than express. I'll move this issue there, @icco.

@rauno56 rauno56 transferred this issue from open-telemetry/opentelemetry-js-contrib Oct 5, 2022
@legendecas
Copy link
Member

The necessary change has been released in @opentelemetry/instrumentation-http v0.33.0. I'm closing this as completed.

@icco
Copy link
Author

icco commented Oct 10, 2022

Just to be clear @legendecas, that change only adds http.client.duration and http.response.duration, the rest of the metrics are still missing.

@icco
Copy link
Author

icco commented Oct 10, 2022

I will try and put together a PR to add those metrics.

@github-actions
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale label Dec 19, 2022
@github-actions
Copy link

github-actions bot commented Jan 9, 2023

This issue was closed because it has been stale for 14 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question User is asking a question not related to a new feature or bug stale
Projects
None yet
Development

No branches or pull requests

4 participants