Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the exactOptionalPropertyTypes tsconfig option #3713

Open
1 of 2 tasks
googol opened this issue Apr 3, 2023 · 7 comments
Open
1 of 2 tasks

Set the exactOptionalPropertyTypes tsconfig option #3713

googol opened this issue Apr 3, 2023 · 7 comments
Labels
enhancement New feature or request needs:code-contribution This feature/bug is ready to implement never-stale up-for-grabs Good for taking. Extra help will be provided by maintainers

Comments

@googol
Copy link

googol commented Apr 3, 2023

Since typescript 4.4 this new tsconfig option has been available, to clarify the difference between { foo: string | undefined } and { foo?: string }. This would be a beneficial option for me to enable in my project, but I cannot as the opentelemetry typings don't typecheck correctly with option.

Affected files that I'm seeing:

Errors  Files
     1  node_modules/@azure/opentelemetry-instrumentation-azure-sdk/node_modules/@opentelemetry/instrumentation/build/src/platform/node/instrumentationNodeModuleDefinition.d.ts:2
     1  node_modules/@opentelemetry/instrumentation-dns/build/src/instrumentation.d.ts:10
     1  node_modules/@opentelemetry/instrumentation-express/build/src/instrumentation.d.ts:9
     1  node_modules/@opentelemetry/instrumentation-http/build/src/http.d.ts:22
     1  node_modules/@opentelemetry/instrumentation-net/build/src/instrumentation.d.ts:5
     1  node_modules/@opentelemetry/instrumentation-pg/build/src/instrumentation.d.ts:9
     1  node_modules/@opentelemetry/instrumentation-winston/build/src/instrumentation.d.ts:5
     1  node_modules/@opentelemetry/instrumentation/build/src/platform/node/instrumentationNodeModuleDefinition.d.ts:2

Link to documentation: https://www.typescriptlang.org/tsconfig#exactOptionalPropertyTypes

  • This only affects the JavaScript OpenTelemetry library
  • This may affect other libraries, but I would like to get opinions here first
@github-actions
Copy link

github-actions bot commented Jun 5, 2023

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale label Jun 5, 2023
@googol
Copy link
Author

googol commented Jun 5, 2023

please consider this change

@github-actions github-actions bot removed the stale label Jun 12, 2023
@voxpelli
Copy link

Seeing this same issue in my projects

@github-actions
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale label Aug 14, 2023
@googol
Copy link
Author

googol commented Aug 14, 2023

Bumping to keep this alive. This is still desired

@dyladan
Copy link
Member

dyladan commented Feb 28, 2024

We talked about this in the SIG meeting and we are generally in favor of this, assuming it doesn't cause issues. I'm going to mark this as up for grabs and PRs will be welcome.

@dyladan dyladan added the up-for-grabs Good for taking. Extra help will be provided by maintainers label Feb 28, 2024
@pichlermarc pichlermarc added enhancement New feature or request needs:code-contribution This feature/bug is ready to implement labels Mar 6, 2024
Copy link

github-actions bot commented Oct 7, 2024

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs:code-contribution This feature/bug is ready to implement never-stale up-for-grabs Good for taking. Extra help will be provided by maintainers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants