Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenCensus trace bridge #3749

Closed
aabmass opened this issue Apr 20, 2023 · 4 comments · Fixed by #3778
Closed

OpenCensus trace bridge #3749

aabmass opened this issue Apr 20, 2023 · 4 comments · Fixed by #3778
Assignees

Comments

@aabmass
Copy link
Member

aabmass commented Apr 20, 2023

Implement the OpenCensus trace bridge part of the spec https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/compatibility/opencensus.md#trace-bridge. Metric bridge is tracked in #3461

Please assign this to me

@Flarna
Copy link
Member

Flarna commented May 5, 2023

I have seen the new package is in folder opentelemetry-shim-opencensus. Recently we dropped the opentelemetry- prefix for new packages. Not sure if it is too late already but maybe we should rename it.

@aabmass
Copy link
Member Author

aabmass commented May 5, 2023

Not too late as the package is still private. Thanks for letting me know, I'll send a PR to fix it.

@llc1123
Copy link
Contributor

llc1123 commented May 10, 2023

I have seen the new package is in folder opentelemetry-shim-opencensus. Recently we dropped the opentelemetry- prefix for new packages. Not sure if it is too late already but maybe we should rename it.

Is it safe removing the prefix of other packages? I don't see any potential problem as the package names keep the same.

@Flarna
Copy link
Member

Flarna commented May 10, 2023

For end users it's fine. It's a bit cumbersome for devs because git is sometimes not that good in showing the history for renames.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants