Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReadableLogRecord trace context fields should be populated from Context #3761

Closed
martinkuba opened this issue Apr 26, 2023 · 0 comments · Fixed by #3817
Closed

ReadableLogRecord trace context fields should be populated from Context #3761

martinkuba opened this issue Apr 26, 2023 · 0 comments · Fixed by #3817
Labels
feature-request sdk:logs Issues and PRs related to the Logs SDK

Comments

@martinkuba
Copy link
Contributor

martinkuba commented Apr 26, 2023

Is your feature request related to a problem? Please describe.

The ReadableLogRecord interface includes trace context fields. These should be automatically populated by the Logger either from the Context that was explicitly passed in or from the active context.

This is described in the spec here.

Also the includeTraceContext configuration should be removed. It is no longer in the spec (link).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request sdk:logs Issues and PRs related to the Logs SDK
Projects
None yet
1 participant