Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Avoid installing unnecessary dependencies #4242

Closed
dyladan opened this issue Nov 1, 2023 · 1 comment · Fixed by #4270
Closed

[CI] Avoid installing unnecessary dependencies #4242

dyladan opened this issue Nov 1, 2023 · 1 comment · Fixed by #4270
Labels
contribfest These small and isolated issues are suitable for Kubecon Contribfest

Comments

@dyladan
Copy link
Member

dyladan commented Nov 1, 2023 

          nit: This `npm install semver` installs all dependencies anyway (npm issue: https://github.com/npm/cli/issues/3023).  This could consider just running `npm ci` OR also installing semver globally (untested): `npm install -g semver`. The latter, if it works, would avoid installing ~800MB of deps.

Originally posted by @trentm in #4238 (comment)
@dyladan dyladan mentioned this issue Nov 1, 2023
Merged
2 tasks
@dyladan dyladan added the contribfest These small and isolated issues are suitable for Kubecon Contribfest label Nov 8, 2023
@strivly
Copy link
Contributor

strivly commented Nov 8, 2023

I'm working on it

strivly pushed a commit to strivly/opentelemetry-js that referenced this issue Nov 8, 2023
fix(ci): install semver package globally open-telemetry#4242
512d0fe 
Signed-off-by: Strivly <contact@strivly.co>
@strivly strivly mentioned this issue Nov 8, 2023
Merged
2 tasks
trentm pushed a commit that referenced this issue Nov 23, 2023
chore(ci): install semver globally to speed up "peer-api" workflow (#…
8067d97 
…4270)

Closes: #4242
dyladan added a commit that referenced this issue Dec 13, 2023
@dyladan @pichlermarc
@trentm @lyzlisa @HyunnoH @seemk @Vunovati @renovate-bot
[next] merge changes from main (#4363)
ea8bfa2 
* Add Trent to approvers (#4311)

* chore(renovate): require dashboard approval for lerna updates (#4276)

* chore(ci): install semver globally to speed up "peer-api" workflow (#4270)

Closes: #4242

* fix(ci): remove token setup via environment variable from .npmrc (#4329)

* fix(instrumentation-http): resume responses when there is no response listener

Fixes a memory leak where unhandled response bodies pile up in node 20

* feat: add script to update changelogs on release preparation (#4315)

* feat: add script to update changelogs on releases

* fix: address comments

* Apply suggestions from code review

Co-authored-by: Trent Mick <trentm@gmail.com>

* fix: apply suggestions from code review

* fix: use packageJson.version instead of version

---------

Co-authored-by: Trent Mick <trentm@gmail.com>

* Fix event name

* test: make rawRequest HTTP-compliant

* Add node 20 to test matrix

* Enable old hash functions on 20

* Fix esm handling for iitm node 20

* Use err.code to make test more reliable

* Changelog

* nit: single import

* Remove unused files

* Add v20 to supported runtimes

* ci: add npm cache in actions/setup-node (#4271)

* feat(sdk-logs): add droppedAttributesCount field to ReadableLogRecord (#4289)

* feat(sdk-logs): add droppedAttributesCount field to ReadableLogRecord

* chore: check droppedAttributesCount value in test case

* feat(otlp-transformer): make toLogRecord() use ReadableLogRecord.droppedAttributesCount

---------

Co-authored-by: Marc Pichler <marc.pichler@dynatrace.com>

* fix(api-logs): allow passing in TimeInput for LogRecord (#4345)

* fix: allow passing in TimeInput for LogRecord

* chore: update changelog

* fix: programmatic url and headers take precedence in metric exporters… (#4334)

* fix: programmatic url and headers take precedence in metric exporters (#2370)

* chore: adjust grpc exporter metrics test

* chore(changelog): update changelog

* fix(instrumentation-http): do not mutate given headers object for outgoing http requests (#4346)

Fixes: open-telemetry/opentelemetry-js-contrib#1609

* chore(deps): update actions/stale action to v9 (#4353)

* fix(deps): update dependency import-in-the-middle to v1.6.0 (#4357)

* chore(deps): update all patch versions (#4306)

* chore(ci): use node 20 in lint workflow (#4359)

* chore(deps): update dependency linkinator to v6 (#4237)

* fix(otlp-exporter-base): decrease default concurrency limit to 30 (#4211)

* fix(otlp-exporter-base): decrease concurrency limit to 30

* fix(changelog): add changelog entry

* chore(deps): use actions/checkout >4 instead of 4.0.0 exactly (#4361)

---------

Co-authored-by: Marc Pichler <marc.pichler@dynatrace.com>
Co-authored-by: strivly <133362191+strivly@users.noreply.github.com>
Co-authored-by: Trent Mick <trentm@gmail.com>
Co-authored-by: lyzlisa <34400837+lyzlisa@users.noreply.github.com>
Co-authored-by: Hyun Oh <hyunnoh01@gmail.com>
Co-authored-by: Siim Kallas <siimkallas@gmail.com>
Co-authored-by: Vladimir Adamić <441333+Vunovati@users.noreply.github.com>
Co-authored-by: Mend Renovate <bot@renovateapp.com>
@strivly strivly removed their assignment Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
contribfest These small and isolated issues are suitable for Kubecon Contribfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(ci): install semver globally to speed up "peer-api" workflow strivly/opentelemetry-js
1 participant
@dyladan