Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update http.* and url.* attributes to align with Semantic Conventions #4724

Closed
MustafaHaddara opened this issue May 21, 2024 · 2 comments
Closed

Comments

@MustafaHaddara
Copy link
Contributor

Is your feature request related to a problem? Please describe.

In open-telemetry/opentelemetry-specification#3355, a host of http.* attributes were updated. Some got moved under url.*, and others got renamed.

From that PR description:

HTTP:

  • http.method -> http.request.method
  • http.status_code -> http.response.status_code
  • http.request_content_length -> http.request.body.size
  • http.response_content_length -> http.response.body.size
  • http.url -> url.full
  • http.target -> url.path + url.query
  • http.scheme -> url.scheme
  • http.client_ip -> not in this PR
  • http.route -> no change
  • http.resend_count -> no change
  • http.request.header.<key> - no change
  • http.response.header.<key> - no change

The largest change seems to be that http.target gets split into two attributes: url.path & url.query.

Describe the solution you'd like

I think we need to update the attributes we emit so that we are aligned with the Semantic Conventions.

In the SIG meeting today we noted that this change will need to wait for #4690 to get merged first, since that PR brings in the latest version of the semantic conventions, and reworks how we get those attributes.

Describe alternatives you've considered

Ignore the semantic conventions? ¯\_(ツ)_/¯

@JamieDanielson
Copy link
Member

@MustafaHaddara this is the current tracking issue for semantic conventions work. We're working on it 😃

@MustafaHaddara
Copy link
Contributor Author

Aha thanks! I didn't see that issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants