Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: relax dependencies of Otel stable in experimental #2848

Closed
wants to merge 5 commits into from

Conversation

Flarna
Copy link
Member

@Flarna Flarna commented Mar 21, 2022

Which problem is this PR solving?

Short description of the changes

Release of experimental and stable is independent.
Relax dependency to avoid that modules get instantiated more then once.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

CI

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

@Flarna Flarna requested a review from a team March 21, 2022 15:18
Release of experimental and stable is independent.
Relax dependency to avoid that modules get instantiated more then once.
@Flarna Flarna force-pushed the experimental-relax-deps branch from 6f5ef28 to 6c6485c Compare March 21, 2022 15:19
@codecov
Copy link

codecov bot commented Mar 21, 2022

Codecov Report

Merging #2848 (dcbef6e) into main (da22673) will decrease coverage by 1.41%.
The diff coverage is n/a.

❗ Current head dcbef6e differs from pull request most recent head 2f9f17b. Consider uploading reports for the commit 2f9f17b to get more accurate results

@@            Coverage Diff             @@
##             main    #2848      +/-   ##
==========================================
- Coverage   93.06%   91.64%   -1.42%     
==========================================
  Files         150       46     -104     
  Lines        4713     1173    -3540     
  Branches      994      274     -720     
==========================================
- Hits         4386     1075    -3311     
+ Misses        327       98     -229     
Impacted Files Coverage Δ
...s/opentelemetry-core/src/platform/node/sdk-info.ts 0.00% <0.00%> (-100.00%) ⬇️
...opentelemetry-core/src/platform/node/globalThis.ts 0.00% <0.00%> (-100.00%) ⬇️
...pentelemetry-core/src/platform/node/performance.ts 0.00% <0.00%> (-100.00%) ⬇️
...lemetry-resources/src/detectors/ProcessDetector.ts 31.81% <0.00%> (-68.19%) ⬇️
...ckages/opentelemetry-exporter-zipkin/src/zipkin.ts 84.48% <0.00%> (-15.52%) ⬇️
...lemetry-resources/src/detectors/BrowserDetector.ts 93.33% <0.00%> (-6.67%) ⬇️
...es/opentelemetry-sdk-metrics-base/src/view/View.ts
...entelemetry-instrumentation-grpc/src/grpc/index.ts
...entelemetry-instrumentation/src/autoLoaderUtils.ts
...emetry-sdk-metrics-base/src/state/MetricStorage.ts
... and 100 more

@Flarna Flarna marked this pull request as draft March 21, 2022 15:31
@Flarna
Copy link
Member Author

Flarna commented Mar 21, 2022

seems this depends on #2835 as the OTLP exporters are currently in nowhere land - not part of stable 1.1.0 release but not yet back in experimental.

@Flarna
Copy link
Member Author

Flarna commented Apr 14, 2022

no longer needed because of #2892

@Flarna Flarna closed this Apr 14, 2022
@Flarna Flarna deleted the experimental-relax-deps branch April 14, 2022 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant