Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update core dependcencies in experimental #2870

Closed
wants to merge 3 commits into from

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Mar 28, 2022

Does what it says on the tin. Doesn't change any version ranges as we can handle that discussion in #2848

@dyladan dyladan requested a review from a team March 28, 2022 13:00
@codecov
Copy link

codecov bot commented Mar 28, 2022

Codecov Report

Merging #2870 (c278929) into main (7870e95) will increase coverage by 1.34%.
The diff coverage is n/a.

❗ Current head c278929 differs from pull request most recent head 497702c. Consider uploading reports for the commit 497702c to get more accurate results

@@            Coverage Diff             @@
##             main    #2870      +/-   ##
==========================================
+ Coverage   93.13%   94.48%   +1.34%     
==========================================
  Files         153       81      -72     
  Lines        5229     2447    -2782     
  Branches     1119      556     -563     
==========================================
- Hits         4870     2312    -2558     
+ Misses        359      135     -224     
Impacted Files Coverage Δ
...etry-exporter-prometheus/src/PrometheusExporter.ts
...e/src/exemplar/SimpleFixedSizeExemplarReservoir.ts
packages/exporter-trace-otlp-http/src/transform.ts
...exporter-metrics-otlp-http/src/transformMetrics.ts
...trics-base/src/exemplar/WithTraceExemplarFilter.ts
...ges/opentelemetry-instrumentation-http/src/http.ts
...entelemetry-sdk-metrics-base/src/view/Predicate.ts
...ackages/opentelemetry-api-metrics/src/NoopMeter.ts
...ry-instrumentation-grpc/src/grpc-js/clientUtils.ts
...s/exporter-trace-otlp-http/src/OTLPExporterBase.ts
... and 79 more

@Flarna
Copy link
Member

Flarna commented Mar 28, 2022

As long as we depend on the 0.27.0 version of metrics-api and metrics-sdk it's most likely not possible to get the tests green.

@dyladan dyladan marked this pull request as draft March 28, 2022 13:28
@dyladan
Copy link
Member Author

dyladan commented Mar 28, 2022

As long as we depend on the 0.27.0 version of metrics-api and metrics-sdk it's most likely not possible to get the tests green.

Marking as draft until we can handle that. #2824 updates the prometheus exporter and @pichlermarc is working on the OTLP exporters. Once those are in it shouldn't be a problem to rename the WIP metrics back to their real names

@legendecas
Copy link
Member

Is this PR still valid after #2871 merged?

@dyladan
Copy link
Member Author

dyladan commented Apr 8, 2022

Is this PR still valid after #2871 merged?

Nope

@dyladan dyladan closed this Apr 8, 2022
@dyladan dyladan deleted the update-core branch April 8, 2022 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants