Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove attributes from OTLPExporterConfigBase #2991

Merged
merged 4 commits into from
May 28, 2022

Conversation

Flarna
Copy link
Member

@Flarna Flarna commented May 24, 2022

Which problem is this PR solving?

Fixes #2826

Short description of the changes

Remove the optional attributes property from OTLPExporterConfigBase because it's not part of the spec and it's actually not exported at all.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

existing tests

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

Remove the optional attributes property from OTLPExporterConfigBase because it's
not part of the spec and it's actually not exported at all.
@Flarna Flarna requested a review from a team May 24, 2022 07:09
@codecov
Copy link

codecov bot commented May 24, 2022

Codecov Report

Merging #2991 (fac212c) into main (edf6157) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2991      +/-   ##
==========================================
- Coverage   92.77%   92.77%   -0.01%     
==========================================
  Files         183      183              
  Lines        6135     6134       -1     
  Branches     1300     1300              
==========================================
- Hits         5692     5691       -1     
  Misses        443      443              
Impacted Files Coverage Δ
...erimental/packages/otlp-exporter-base/src/types.ts 16.66% <ø> (ø)
...ackages/otlp-exporter-base/src/OTLPExporterBase.ts 95.12% <100.00%> (-0.12%) ⬇️

Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for removing this. 🙂 I must have glanced over that without noticing more than a hundred times. 😅

@vmarchaud vmarchaud merged commit e44f6d1 into open-telemetry:main May 28, 2022
@Flarna Flarna deleted the rm-otlp-attrib branch May 28, 2022 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

attributes config in OTLPExporters
4 participants