Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update changelog to reflect #3098 fixed #2791 #3111

Merged
merged 2 commits into from
Jul 26, 2022

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Jul 25, 2022

This is simply updating the changelog to reflect that a bug was fixed while implementing another feature.

@dyladan dyladan requested a review from a team July 25, 2022 18:28
@dyladan
Copy link
Member Author

dyladan commented Jul 25, 2022

This is fixed by #3098

The root cause was that the ExportRequestProto was a module-level global in a module which was a base class for the metric and trace exporters (old source). @legendecas fixed this while converting the proto exporters to use precompiled JS instead of loading protos in #3098 (link to PR lines) (new source).

originally posted in #2791 (comment)

@codecov
Copy link

codecov bot commented Jul 25, 2022

Codecov Report

Merging #3111 (cef3e51) into main (5ae0a37) will not change coverage.
The diff coverage is n/a.

❗ Current head cef3e51 differs from pull request most recent head 8ef4184. Consider uploading reports for the commit 8ef4184 to get more accurate results

@@           Coverage Diff           @@
##             main    #3111   +/-   ##
=======================================
  Coverage   93.11%   93.11%           
=======================================
  Files         189      189           
  Lines        6276     6276           
  Branches     1319     1319           
=======================================
  Hits         5844     5844           
  Misses        432      432           

@dyladan dyladan merged commit 79cb83d into open-telemetry:main Jul 26, 2022
@dyladan dyladan deleted the changelog-3098-bug branch July 26, 2022 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants