Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cleanup eslint #3209

Merged

Conversation

pichlermarc
Copy link
Member

Which problem is this PR solving?

eslint rules @typescript-eslint/no-shadow (for *.ts) and @typescript-eslint/no-floating-promises (for test/**/*.ts) were duplicated.

This PR removes the duplicated @typescript-eslint/no-shadow rule and uses the newer entry for @typescript-eslint/no-floating-promises.

@pichlermarc pichlermarc requested a review from a team August 29, 2022 11:34
@codecov
Copy link

codecov bot commented Aug 29, 2022

Codecov Report

Merging #3209 (0a4ec46) into main (d4ab03f) will decrease coverage by 1.06%.
The diff coverage is n/a.

❗ Current head 0a4ec46 differs from pull request most recent head 2206135. Consider uploading reports for the commit 2206135 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3209      +/-   ##
==========================================
- Coverage   93.21%   92.15%   -1.07%     
==========================================
  Files         196       87     -109     
  Lines        6443     2497    -3946     
  Branches     1363      547     -816     
==========================================
- Hits         6006     2301    -3705     
+ Misses        437      196     -241     
Impacted Files Coverage Δ
...s/opentelemetry-core/src/platform/node/sdk-info.ts 0.00% <0.00%> (-100.00%) ⬇️
...opentelemetry-core/src/platform/node/globalThis.ts 0.00% <0.00%> (-100.00%) ⬇️
...pentelemetry-core/src/platform/node/performance.ts 0.00% <0.00%> (-100.00%) ⬇️
...emetry-api-metrics/src/platform/node/globalThis.ts 0.00% <0.00%> (-100.00%) ⬇️
...lemetry-resources/src/detectors/ProcessDetector.ts 31.81% <0.00%> (-68.19%) ⬇️
...perimental/packages/otlp-exporter-base/src/util.ts 79.41% <0.00%> (-17.65%) ⬇️
...ckages/opentelemetry-exporter-zipkin/src/zipkin.ts 84.48% <0.00%> (-15.52%) ⬇️
...lemetry-resources/src/detectors/BrowserDetector.ts 93.33% <0.00%> (-6.67%) ⬇️
...ges/opentelemetry-sdk-metrics/src/state/HashMap.ts
...-trace-base/src/platform/node/RandomIdGenerator.ts
... and 107 more

@dyladan dyladan merged commit bd9159a into open-telemetry:main Aug 29, 2022
@dyladan dyladan deleted the chore/cleanup-eslint branch August 29, 2022 20:45
pichlermarc added a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants