fix(instrumentation-http): resume responses when there is no response… #4332
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4316
There is a memory leak in node 20 which is a manifestation of a problem that has been around for a while. If a user makes an http request and doesn't add a
response
listener to the request, the response body is typically dropped by the node runtime. The HTTP instrumentation adds a listener, which prevents the runtime from dropping the body. We shouldresume
the response in order to put the stream back into flowing mode, which will cause the runtime to have the correct behavior after our callback returns.This is fixed in the
next
branch by #4331 but if this merges first I will remove it from there.