Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: make rawRequest HTTP-compliant #4335

Merged
merged 3 commits into from
Nov 30, 2023
Merged

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Nov 30, 2023

This causes node 20 tests to fail on the next branch. Fixing here because it is required by HTTP spec.

@dyladan dyladan requested a review from a team November 30, 2023 13:39
Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Merging #4335 (0a52166) into main (cc4ff2d) will decrease coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4335      +/-   ##
==========================================
- Coverage   92.30%   92.29%   -0.02%     
==========================================
  Files         330      330              
  Lines        9426     9426              
  Branches     1999     1999              
==========================================
- Hits         8701     8700       -1     
- Misses        725      726       +1     

see 1 file with indirect coverage changes

Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks 🙂

@dyladan dyladan merged commit 593d220 into open-telemetry:main Nov 30, 2023
19 checks passed
@dyladan dyladan deleted the node-20-test branch November 30, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants