From 9db157e87f6f0f6b939f109810f1c562e2c0c6e2 Mon Sep 17 00:00:00 2001 From: Marc Pichler Date: Mon, 2 Dec 2024 18:22:38 +0100 Subject: [PATCH] fix: de-confuse build tooling by not using 'export *' in comments --- experimental/CHANGELOG.md | 2 ++ experimental/packages/exporter-logs-otlp-grpc/src/index.ts | 2 +- experimental/packages/exporter-trace-otlp-grpc/src/index.ts | 2 +- experimental/packages/exporter-trace-otlp-http/src/index.ts | 2 +- .../exporter-trace-otlp-http/src/platform/browser/index.ts | 2 +- .../packages/exporter-trace-otlp-http/src/platform/index.ts | 2 +- .../exporter-trace-otlp-http/src/platform/node/index.ts | 2 +- .../opentelemetry-exporter-metrics-otlp-grpc/src/index.ts | 2 +- .../opentelemetry-exporter-metrics-otlp-proto/src/index.ts | 2 +- experimental/packages/opentelemetry-sdk-node/src/index.ts | 2 +- 10 files changed, 11 insertions(+), 9 deletions(-) diff --git a/experimental/CHANGELOG.md b/experimental/CHANGELOG.md index a888113b1e4..9951ef26f48 100644 --- a/experimental/CHANGELOG.md +++ b/experimental/CHANGELOG.md @@ -30,6 +30,8 @@ All notable changes to experimental packages in this project will be documented ### :bug: (Bug Fix) +* fix(otlp-exporter-\*): de-confuse Nuxt build tooling by not using 'export *' in comments [#5227](https://github.com/open-telemetry/opentelemetry-js/pull/5227) @pichlermarc + ### :books: (Refine Doc) ### :house: (Internal) diff --git a/experimental/packages/exporter-logs-otlp-grpc/src/index.ts b/experimental/packages/exporter-logs-otlp-grpc/src/index.ts index 2edd35dc611..1c9dce18f30 100644 --- a/experimental/packages/exporter-logs-otlp-grpc/src/index.ts +++ b/experimental/packages/exporter-logs-otlp-grpc/src/index.ts @@ -15,6 +15,6 @@ */ /* eslint no-restricted-syntax: ["warn", "ExportAllDeclaration"] -- - * TODO: Replace export * with named exports before next major version + * TODO: Replace wildcard export with named exports before next major version */ export * from './OTLPLogExporter'; diff --git a/experimental/packages/exporter-trace-otlp-grpc/src/index.ts b/experimental/packages/exporter-trace-otlp-grpc/src/index.ts index 5a3361b4cfa..4680586a1d3 100644 --- a/experimental/packages/exporter-trace-otlp-grpc/src/index.ts +++ b/experimental/packages/exporter-trace-otlp-grpc/src/index.ts @@ -15,6 +15,6 @@ */ /* eslint no-restricted-syntax: ["warn", "ExportAllDeclaration"] -- - * TODO: Replace export * with named exports before next major version + * TODO: Replace wildcard export with named exports before next major version */ export * from './OTLPTraceExporter'; diff --git a/experimental/packages/exporter-trace-otlp-http/src/index.ts b/experimental/packages/exporter-trace-otlp-http/src/index.ts index 44d69b8bb64..70c8d9108d9 100644 --- a/experimental/packages/exporter-trace-otlp-http/src/index.ts +++ b/experimental/packages/exporter-trace-otlp-http/src/index.ts @@ -15,6 +15,6 @@ */ /* eslint no-restricted-syntax: ["warn", "ExportAllDeclaration"] -- - * TODO: Replace export * with named exports before next major version + * TODO: Replace wildcard export with named exports before next major version */ export * from './platform'; diff --git a/experimental/packages/exporter-trace-otlp-http/src/platform/browser/index.ts b/experimental/packages/exporter-trace-otlp-http/src/platform/browser/index.ts index 5a3361b4cfa..4680586a1d3 100644 --- a/experimental/packages/exporter-trace-otlp-http/src/platform/browser/index.ts +++ b/experimental/packages/exporter-trace-otlp-http/src/platform/browser/index.ts @@ -15,6 +15,6 @@ */ /* eslint no-restricted-syntax: ["warn", "ExportAllDeclaration"] -- - * TODO: Replace export * with named exports before next major version + * TODO: Replace wildcard export with named exports before next major version */ export * from './OTLPTraceExporter'; diff --git a/experimental/packages/exporter-trace-otlp-http/src/platform/index.ts b/experimental/packages/exporter-trace-otlp-http/src/platform/index.ts index 65e269f6773..5b5a74b7e4f 100644 --- a/experimental/packages/exporter-trace-otlp-http/src/platform/index.ts +++ b/experimental/packages/exporter-trace-otlp-http/src/platform/index.ts @@ -15,6 +15,6 @@ */ /* eslint no-restricted-syntax: ["warn", "ExportAllDeclaration"] -- - * TODO: Replace export * with named exports before next major version + * TODO: Replace wildcard export with named exports before next major version */ export * from './node'; diff --git a/experimental/packages/exporter-trace-otlp-http/src/platform/node/index.ts b/experimental/packages/exporter-trace-otlp-http/src/platform/node/index.ts index 5a3361b4cfa..4680586a1d3 100644 --- a/experimental/packages/exporter-trace-otlp-http/src/platform/node/index.ts +++ b/experimental/packages/exporter-trace-otlp-http/src/platform/node/index.ts @@ -15,6 +15,6 @@ */ /* eslint no-restricted-syntax: ["warn", "ExportAllDeclaration"] -- - * TODO: Replace export * with named exports before next major version + * TODO: Replace wildcard export with named exports before next major version */ export * from './OTLPTraceExporter'; diff --git a/experimental/packages/opentelemetry-exporter-metrics-otlp-grpc/src/index.ts b/experimental/packages/opentelemetry-exporter-metrics-otlp-grpc/src/index.ts index 231f75b5937..59fbfabe094 100644 --- a/experimental/packages/opentelemetry-exporter-metrics-otlp-grpc/src/index.ts +++ b/experimental/packages/opentelemetry-exporter-metrics-otlp-grpc/src/index.ts @@ -15,6 +15,6 @@ */ /* eslint no-restricted-syntax: ["warn", "ExportAllDeclaration"] -- - * TODO: Replace export * with named exports before next major version + * TODO: Replace wildcard export with named exports before next major version */ export * from './OTLPMetricExporter'; diff --git a/experimental/packages/opentelemetry-exporter-metrics-otlp-proto/src/index.ts b/experimental/packages/opentelemetry-exporter-metrics-otlp-proto/src/index.ts index 231f75b5937..59fbfabe094 100644 --- a/experimental/packages/opentelemetry-exporter-metrics-otlp-proto/src/index.ts +++ b/experimental/packages/opentelemetry-exporter-metrics-otlp-proto/src/index.ts @@ -15,6 +15,6 @@ */ /* eslint no-restricted-syntax: ["warn", "ExportAllDeclaration"] -- - * TODO: Replace export * with named exports before next major version + * TODO: Replace wildcard export with named exports before next major version */ export * from './OTLPMetricExporter'; diff --git a/experimental/packages/opentelemetry-sdk-node/src/index.ts b/experimental/packages/opentelemetry-sdk-node/src/index.ts index 5b296eb3bd1..9a1df39c800 100644 --- a/experimental/packages/opentelemetry-sdk-node/src/index.ts +++ b/experimental/packages/opentelemetry-sdk-node/src/index.ts @@ -15,7 +15,7 @@ */ /* eslint no-restricted-syntax: ["warn", "ExportAllDeclaration"] -- - * TODO: Replace export * with named exports before next major version + * TODO: Replace wildcard export with named exports before next major version */ export * as api from '@opentelemetry/api'; export * as contextBase from '@opentelemetry/api';