Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependabot not updating dependencies for OpenTelemetry Lambda JS #1421

Open
vasireddy99 opened this issue Jul 10, 2024 · 2 comments
Open

Dependabot not updating dependencies for OpenTelemetry Lambda JS #1421

vasireddy99 opened this issue Jul 10, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@vasireddy99
Copy link
Contributor

vasireddy99 commented Jul 10, 2024

Describe the bug

It appears that Dependabot, is not updating the dependencies for Node.js release. dependencies that are not updated.

Lambda Nodejs Layer 0.7.0 claims to be at version otel js 1.24.1, but the dependencies are not updated in the corresponding release

@vasireddy99 vasireddy99 added the bug Something isn't working label Jul 10, 2024
@tylerbenson
Copy link
Member

tylerbenson commented Jul 11, 2024

1.24.1 was the version reported by the build: https://github.com/open-telemetry/opentelemetry-lambda/actions/runs/9355724499 (component-version=1.24.1)
(which invokes version.js)
Maybe that is reporting the version incorrectly or it's being transitively updated?

@rapphil
Copy link
Contributor

rapphil commented Jul 22, 2024

We are using caret in the version of the dependencies: https://github.com/npm/node-semver?tab=readme-ov-file#caret-ranges-123-025-004

This makes the dependency to be resolved in build time.

We could use a package-lock.json or explicitly set the the version instead of using caret. Since this is somewhat a library I would prefer to make it explicit in package.json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants