Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NathanielRN to repo approvers #151

Closed
NathanielRN opened this issue Oct 5, 2021 · 5 comments
Closed

Add NathanielRN to repo approvers #151

NathanielRN opened this issue Oct 5, 2021 · 5 comments

Comments

@NathanielRN
Copy link
Contributor

NathanielRN commented Oct 5, 2021

Description

The AWS Observability team continues to make improvements to the OTel + AWS experience. I have had the chance to work on OpenTelemetry for the last year, and have made contributions to this repo as well. See:

#110
#148
#150
#124

I have experience contributing to OpenTelemetry repos, especially including OTel Python. Give all of this, I'm requesting to be added as an maintainer approver to this opentelemetry-lambda repo so I can help with reviews and have less resistance as I continue to work on new feature to the repo. I believe my experience will help me make positive contributions to this project.

Thank you! 🙂

Tag @codeboten

@wangzlei
Copy link
Contributor

wangzlei commented Oct 6, 2021

+1

@anuraaga
Copy link
Contributor

anuraaga commented Oct 6, 2021

I think in most OTel repos, we generally start with adding to approvers and later after showing work on broad technical issues in that repo could step up to maintainer (initial bootstrapping of a repo may be lax here out of necessity). I think your work looks good for being added as an approver, how does that sound? It won't particularly address "have less resistance as I continue to work on new feature to the repo" but I hope having a team member and other members from AWS in maintainers will keep you unblocked.

For reference, here are the responsibilities for approver and maintainer.
https://github.com/open-telemetry/community/blob/main/community-membership.md#approver

@NathanielRN
Copy link
Contributor Author

Sure! An approver role is fine with me. I'll update the issue description.

@NathanielRN NathanielRN changed the title Add NathanielRN to repo maintainers Add NathanielRN to repo ~maintainers~ approvers Oct 6, 2021
@NathanielRN NathanielRN changed the title Add NathanielRN to repo ~maintainers~ approvers Add NathanielRN to repo approvers Oct 6, 2021
@anuraaga
Copy link
Contributor

anuraaga commented Oct 6, 2021

Cool! @codeboten I think you're the only one that can edit the teams, can you add @NathanielRN to https://github.com/orgs/open-telemetry/teams/lambda-extension-approvers/members? Also is it possible to set it so all the maintainers are able to do that?

@codeboten
Copy link
Contributor

@NathanielRN added, also updated the group to ensure all maintainers can manage permissions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants