-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kernel-collector doesn't start on systems with more than 128 logical CPUs #258
Comments
Yes there should be an artificial upper limit to the number of CPUs, that is used to allocate some static memory in the kernel collector. There is no inherent limitation to the number of CPUs that would be supported. I think the current limitation would only manifest in:
Happy to review a patch if you have the bandwidth! cc @open-telemetry/network-maintainers if you remember anywhere else the CPU core count would manifest |
After some further investigation:
Looking at mentions of
Bottom line, I think just increasing |
@yonch, if this issue is still open, can you please review the PR |
What happened?
Description
kernel-collector fails to start on a system with more than 128 logical CPUs
Steps to Reproduce
run on baremetal server with 256 CPUs
Expected Result
running
Actual Result
failed with error
eBPF Collector version
v0.10.2
Environment information
Environment
OS: Debian GNU/Linux 11 (bullseye)
Kernel: 6.0.0-0.deb11.2-amd64 (with installed linux-headers-amd64)
eBPF Collector configuration
default
Log output
Additional context
most likely
BPF_MAX_CPUS
constant should be increased hereopentelemetry-network/collector/kernel/bpf_src/render_bpf.h
Line 14 in 0e33f66
The text was updated successfully, but these errors were encountered: