-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create OpenShift dashboard to visualize Collector metrics #2996
Conversation
…try#2995 Signed-off-by: Israel Blancas <iblancasa@gmail.com>
@pavolloffay anything else? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I would just document how to maintain the dashboard JSON, How it is created, how it can be modified.
…or into feature/2995
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
"k8s.io/client-go/kubernetes" | ||
) | ||
|
||
// The dashboard is created manually following the syntax from Grafana 5. For development purposes, this dashboard can be created just loading the JSON file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just by
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
…or into feature/2995
…rator into feature/2995
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
@swiatekm could you please review? |
# (Optional) One or more lines of additional information to render under the primary note. | ||
# These lines will be padded with 2 spaces and then inserted directly into the document. | ||
# Use pipe (|) for multiline entries. | ||
subtext: To enable this feature, you need to specify the `--create-openshift-dashboard` argument to the operator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it make sense to start openshift specific flags with an --openshift-*
prefix?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's a nice idea :)
@swiatekm please, can you review? |
…rator into feature/2995
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
Description: this PR adds the creation of OpenShift dashboards to monitor OpenTelemetry Collector instances.