Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target Allocator doesn't accept only target_allocator config in the collector config #2998

Open
jaronoff97 opened this issue May 29, 2024 · 3 comments
Assignees
Labels
area:target-allocator Issues for target-allocator bug Something isn't working good first issue Good for newcomers

Comments

@jaronoff97
Copy link
Contributor

Component(s)

target allocator

What happened?

Description

The target allocator is supposed to be able accept only the target_allocator configuration, but right now it errors when doing so.

Steps to Reproduce

Create a collector with the target_allocator section set:

prometheus:
        target_allocator:
          endpoint: xxxxxxx
          interval: 30s
          collector_id: ${POD_NAME}

Expected Result

Actual Result

{"level":"ERROR","timestamp":"2024-05-29T17:17:58Z","logger":"controllers.OpenTelemetryCollector","message":"Failed to create manifest.Params","opentelemetrycollector":{"name":"colossus-us-sjc45-prd-mon1","namespace":"platform-engineering-resources"},"error":"no prometheusConfig available as part of the configuration","stacktrace":"[github.com/open-telemetry/opentelemetry-operator/controllers.(*OpenTelemetryCollectorReconciler).Reconcile](http://github.com/open-telemetry/opentelemetry-operator/controllers.(*OpenTelemetryCollectorReconciler).Reconcile)\n\t/home/runner/work/opentelemetry-operator/opentelemetry-operator/controllers/opentelemetrycollector_controller.go:236\[nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile](http://nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile)\n\t/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.17.3/pkg/internal/controller/controller.go:119\[nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler](http://nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler)\n\t/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.17.3/pkg/internal/controller/controller.go:316\[nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem](http://nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem)\n\t/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.17.3/pkg/internal/controller/controller.go:266\[nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2](http://nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2)\n\t/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.17.3/pkg/internal/controller/controller.go:227"}

Kubernetes Version

1.29.0

Operator version

0.100.1

Collector version

0.101.0

Environment information

Environment

OS: (e.g., "Ubuntu 20.04")
Compiler(if manually compiled): (e.g., "go 14.2")

Log output

No response

Additional context

No response

@jaronoff97 jaronoff97 added bug Something isn't working needs triage labels May 29, 2024
@jaronoff97
Copy link
Contributor Author

it would also be great if the target-allocators per-node strategy said which job was lacking the node metadata info for the per-node strategy!

@jaronoff97 jaronoff97 added good first issue Good for newcomers area:target-allocator Issues for target-allocator and removed needs triage labels May 29, 2024
@parambath92
Copy link

Hi @jaronoff97, I would like work on this issue. Can you please assign this to me ?

@jaronoff97
Copy link
Contributor Author

@parambath92 sure! let me know if you need any assistance in getting started!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:target-allocator Issues for target-allocator bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants