Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exemplar spec is not yet stable #1088

Closed
brettmc opened this issue Jul 19, 2023 · 2 comments · Fixed by #1091
Closed

Exemplar spec is not yet stable #1088

brettmc opened this issue Jul 19, 2023 · 2 comments · Fixed by #1091
Labels
bug Something isn't working signal:metrics Related to metrics signal tc-review technical committee review feedback

Comments

@brettmc
Copy link
Collaborator

brettmc commented Jul 19, 2023

From open-telemetry/community#1536 (comment)

Exemplar spec is not yet stable https://github.com/open-telemetry/opentelemetry-php/tree/cc92a07eac5294055b0d477fb7e47d6480381505/src/SDK/Metrics/Exemplar.
@brettmc brettmc added bug Something isn't working tc-review technical committee review feedback signal:metrics Related to metrics signal labels Jul 19, 2023
@brettmc
Copy link
Collaborator Author

brettmc commented Jul 19, 2023

It looks like examplars were recently made explicitly unstable in open-telemetry/opentelemetry-specification#3533
Java SIG has documented in code that exemplars are experimental and have unstable APIs, this might be the best approach for us too.

@brettmc brettmc mentioned this issue Jul 27, 2023
Merged
@brettmc
Copy link
Collaborator Author

brettmc commented Jul 27, 2023

Java's approach, for reference: open-telemetry/opentelemetry-java@322097a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working signal:metrics Related to metrics signal tc-review technical committee review feedback
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

document that examplars are not stable brettmc/opentelemetry-php
1 participant
@brettmc