Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename ProbabilitySampler to TraceIdRatioBased #221

Merged
merged 1 commit into from
Sep 17, 2020
Merged

Rename ProbabilitySampler to TraceIdRatioBased #221

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions opentelemetry/proto/trace/v1/trace_config.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ message TraceConfig {
oneof sampler {
ConstantSampler constant_sampler = 1;

ProbabilitySampler probability_sampler = 2;
TraceIdRatioBased trace_id_ratio_based = 2;

RateLimitingSampler rate_limiting_sampler = 3;
}
Expand Down Expand Up @@ -64,11 +64,11 @@ message ConstantSampler {
ConstantDecision decision = 1;
}

// Sampler that tries to uniformly sample traces with a given probability.
// The probability of sampling a trace is equal to that of the specified probability.
message ProbabilitySampler {
// The desired probability of sampling. Must be within [0.0, 1.0].
double samplingProbability = 1;
// Sampler that tries to uniformly sample traces with a given ratio.
// The ratio of sampling a trace is equal to that of the specified ratio.
message TraceIdRatioBased {
// The desired ratio of sampling. Must be within [0.0, 1.0].
double samplingRatio = 1;
}

// Sampler that tries to sample with a rate per time window.
Expand Down